Review Request: Make AccountListModel comply to ModelTest
Dominik Schmidt
ich at dominik-schmidt.de
Fri Jan 21 19:58:43 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100431/#review1015
-----------------------------------------------------------
src/accounts-list-model.cpp
<http://git.reviewboard.kde.org/r/100431/#comment811>
These comments should be removed.
src/accounts-list-model.cpp
<http://git.reviewboard.kde.org/r/100431/#comment812>
These whitespaces should be removed as well.
Good you finished it.
- Dominik
On Jan. 21, 2011, 6:48 p.m., Thomas Richard wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100431/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2011, 6:48 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> The AccountListModel passes the ModelTest with this patch
>
> Thanks to Dominik Schmidt
>
>
> Diffs
> -----
>
> src/accounts-list-model.h fa67492ccd299574b5be244513a788e71f4799b3
> src/accounts-list-model.cpp b51e4f13aac186ecb53e9948546e1bc2c55c7f25
>
> Diff: http://git.reviewboard.kde.org/r/100431/diff
>
>
> Testing
> -------
>
> Run ModelTest
> Add, edit and remove accounts
>
>
> Thanks,
>
> Thomas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110121/2e3c75e1/attachment-0001.htm
More information about the KDE-Telepathy
mailing list