Review Request: Only show real profiles and fake profiles for protocols, which do not have a real profile.

[Dominik Schmidt]

> On Jan. 17, 2011, 7:01 p.m., David Edmundson wrote:
> > src/KCMTelepathyAccounts/profile-list-model.cpp, line 98
> > <http://git.reviewboard.kde.org/r/100407/diff/1/?file=7189#file7189line98>
> >
> >     it should bebeginsertrows(index, 0, size()-1) 
> >     
> >     as the third parameter is not the number of items to be inserted but the last index.

How did you find out? :-P


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100407/#review976
-----------------------------------------------------------


On Jan. 17, 2011, 4:26 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100407/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2011, 4:26 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Only show real profiles and fake profiles for protocols, which do not have a real profile.
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/profile-list-model.h 0025a95 
>   src/KCMTelepathyAccounts/profile-list-model.cpp eee1187 
> 
> Diff: http://git.reviewboard.kde.org/r/100407/diff
> 
> 
> Testing
> -------
> 
> Added a Google Talk and a (Gabble-)Jabber profile. The latter hides Haze-Jabber. No impacts on Google Talk though.
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110120/a3bb1d04/attachment-0001.htm