Review Request: Sort profile list alphabetically
Thomas Richard
thomas.richard at proan.be
Mon Jan 17 19:57:55 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100419/#review975
-----------------------------------------------------------
Ship it!
Looks good
src/KCMTelepathyAccounts/profile-select-widget.cpp
<http://git.reviewboard.kde.org/r/100419/#comment793>
I'd say #include <QItemSelectionModel> looks better
src/KCMTelepathyAccounts/profile-select-widget.cpp
<http://git.reviewboard.kde.org/r/100419/#comment794>
extra whitespace
- Thomas
On Jan. 17, 2011, 6:42 p.m., Dominik Schmidt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100419/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2011, 6:42 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Sort profile list alphabetically
>
>
> Diffs
> -----
>
> src/KCMTelepathyAccounts/profile-select-widget.cpp ad6dcf7
>
> Diff: http://git.reviewboard.kde.org/r/100419/diff
>
>
> Testing
> -------
>
> It sorts ... :P
>
> If you select a profile you can edit it afterwards (the right one is mapped from the proxy model).
>
>
> Thanks,
>
> Dominik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110117/e11b1dd3/attachment-0001.htm
More information about the KDE-Telepathy
mailing list