Review Request: Add some forgotten deletes, fix some fixme's and remove unneeded todo's

Thomas Richard thomas.richard at proan.be
Sun Jan 16 18:24:39 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100399/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Added some deletes that were forgotten
Fixed a fixme in ParameterEditModel
Removed unneeded TODOs (I checked if there was something that needs to be deleted)
Fixed icons in the ProfileListModel


Diffs
-----

  src/KCMTelepathyAccounts/generic-advanced-options-widget.cpp afef04cd589695983dfade94f3b5da58f2c21f40 
  src/KCMTelepathyAccounts/parameter-edit-delegate.cpp 057a76dc9f953eb5205fcb64f94a9e8b892427e1 
  src/KCMTelepathyAccounts/parameter-edit-model.cpp 557fe221836761a64a189d0b0271112eb7aec0db 
  src/KCMTelepathyAccounts/profile-item.h 31c1e18fcf63838ed994b1d619f3622e397d587c 
  src/KCMTelepathyAccounts/profile-item.cpp 99ff61fb133820b3d4e2e97b6ec53bfef90b3860 
  src/KCMTelepathyAccounts/profile-list-model.cpp bb68338d06578692a5db8634c7eb107b5bd603f1 
  src/accounts-list-model.cpp 5ceaa9a9616cc8e09e11b9de650b791d0fef9cba 
  src/edit-account-dialog.cpp 6f88e7c64df85bf8ae22aef5f75ad167d9d8847b 
  src/kcm-telepathy-accounts.h a8961f7169e52f47e7cec15acc2b24a9587c88bd 
  src/kcm-telepathy-accounts.cpp 5723319d374c6788aece56c96d5ae6b75b58093b 

Diff: http://git.reviewboard.kde.org/r/100399/diff


Testing
-------

Compiling and adding/editing/deleting accounts
Visually confirmed that icons in the ProfileSelectWidget work again


Thanks,

Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110116/8e0548fb/attachment.htm 


More information about the KDE-Telepathy mailing list