Review Request: Make the accounts kcm use profiles instead of protocols

[Thomas Richard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100389/
-----------------------------------------------------------

(Updated Jan. 14, 2011, 11:44 p.m.)


Review request for Telepathy.


Changes
-------

Implemented David's suggestions. Looking much better.


Summary
-------

This change makes the accounts kcm use profiles. In the near future, distros should start shipping profiles. 

This will make it possible to show 'Google talk' and 'Facebook chat' in the new accounts dialog instead of 'Jabber/XMPP/Google Talk'. 
It also allows to do small modifications in the plugins, depending on the selected profile. 
It can provide different default parameters for different profiles.
Last but not least, the icons used can (or must) be specified in the profile.


Diffs (updated)
-----

  src/KCMTelepathyAccounts/CMakeLists.txt 1e3a282f64bc66a18765a0499492296c222e94dd 
  src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp fb29cc3fc95c3543bd2dda66d474a7ebba19c94a 
  src/KCMTelepathyAccounts/abstract-account-ui-plugin.h 87eddd9c2a6e8c9beba786d5a40c4acf1c0e347c 
  src/KCMTelepathyAccounts/account-edit-widget.h 95e29238ffd83530a6005c290c1e3e8ed00d87c0 
  src/KCMTelepathyAccounts/account-edit-widget.cpp 224dab9e40c282b20db69287f8c59a4c04b84d07 
  src/KCMTelepathyAccounts/connection-manager-item.h aa3480eeecff4be8433d5a11236c40f1ffbbbe16 
  src/KCMTelepathyAccounts/connection-manager-item.cpp 91eea62bd4e0fbf2a746424d99a025ef4d4261d3 
  src/KCMTelepathyAccounts/dictionary.cpp 2eeff58ee489fe1b95c46d9c53e83ce42afc0ae4 
  src/KCMTelepathyAccounts/generic-advanced-options-widget.h ac5ff029ba8e86e0adf6f6a3988609d5c1ae6665 
  src/KCMTelepathyAccounts/generic-advanced-options-widget.cpp 0e39b47fbd214ef66b3af1732bf7dc0c1858a8c4 
  src/KCMTelepathyAccounts/parameter-edit-model.h 44c9d4dcc5300f0734c2c7aa12e4d0d050b48aec 
  src/KCMTelepathyAccounts/parameter-edit-model.cpp d64fea0532f0b3a615ee69aa3236d32582c1a839 
  src/KCMTelepathyAccounts/parameter-item.cpp 65e4334de625804c3277424dbca28b5f2d4dbf28 
  src/KCMTelepathyAccounts/plugin-manager.h 8f6ff41655fb35dad4059992b84db81b28c54525 
  src/KCMTelepathyAccounts/plugin-manager.cpp e04088f7ffd1e8b720059343bf1cb614ebf69252 
  src/KCMTelepathyAccounts/profile-item.h PRE-CREATION 
  src/KCMTelepathyAccounts/profile-item.cpp PRE-CREATION 
  src/KCMTelepathyAccounts/profile-list-model.h PRE-CREATION 
  src/KCMTelepathyAccounts/profile-list-model.cpp PRE-CREATION 
  src/KCMTelepathyAccounts/profile-select-widget.h PRE-CREATION 
  src/KCMTelepathyAccounts/profile-select-widget.cpp PRE-CREATION 
  src/KCMTelepathyAccounts/profile-select-widget.ui PRE-CREATION 
  src/KCMTelepathyAccounts/protocol-item.h 759956e11e05e57ccafb2baae3314816b9122b49 
  src/KCMTelepathyAccounts/protocol-item.cpp 2a6844349ee8e16b4e8c6a9d274c77d51ffb69fb 
  src/KCMTelepathyAccounts/protocol-list-model.h 3718e8fc0b4093ab70e4528efecdf3538abb0825 
  src/KCMTelepathyAccounts/protocol-list-model.cpp 168c6c57c2db993a1d71f56678e2fbaa061aa953 
  src/KCMTelepathyAccounts/protocol-select-widget.h ca0bd8a8468a76b89f24b477c050c39acba6aa0b 
  src/KCMTelepathyAccounts/protocol-select-widget.cpp f53c5b7529f288efec0b9c1bd232d34b6b380a60 
  src/KCMTelepathyAccounts/protocol-select-widget.ui d6aee67d461c574f139ebf74908acaecd193a0e2 
  src/account-item.cpp a670a1be35bd2edb71683f918756de9edb91a1c8 
  src/add-account-assistant.h b16d76b14ff5d871287610ce0be400188f84d3f8 
  src/add-account-assistant.cpp 69edc1171798f80ee5ac8c5c9853907ff039d76e 
  src/edit-account-dialog.cpp 979742196c880f34a5df3345b509ffb945328613 
  src/kcm-telepathy-accounts.cpp 554f6d1d719cca651f86a7df6e9700970552cec6 

Diff: http://git.reviewboard.kde.org/r/100389/diff


Testing
-------

Compiling
Adding new accounts
Editing accounts
Added the sample profile from:
http://telepathy.freedesktop.org/wiki/service-profile-v1
Everything seems to work as seen in the screenshots


Screenshots
-----------


  http://git.reviewboard.kde.org/r/100389/s/43/

  http://git.reviewboard.kde.org/r/100389/s/44/

  http://git.reviewboard.kde.org/r/100389/s/45/


Thanks,

Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110114/9f5e3d0c/attachment.html