Review Request: gabble: use QFormLayout for main options widget

David Edmundson kde at davidedmundson.co.uk
Fri Jan 14 00:04:33 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100384/#review878
-----------------------------------------------------------

Ship it!


Looks good.

- David


On Jan. 13, 2011, 11:02 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100384/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2011, 11:02 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> remove multiple, nested Q[VH]BoxLayouts and use one QFormLayout
> 
> 
> Diffs
> -----
> 
>   gabble/main-options-widget.ui 5e56e335ed44a61e1e386b09c6b14db9d284b3d9 
> 
> Diff: http://git.reviewboard.kde.org/r/100384/diff
> 
> 
> Testing
> -------
> 
> looks good, even with translated labels ;)
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110113/d70f54a3/attachment-0001.htm 


More information about the KDE-Telepathy mailing list