Review Request: Add account online-ness to the model.

[Thomas Richard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100369/#review843
-----------------------------------------------------------


The result looks very good. I think you forgot to merge with master before making this patch though.


src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/100369/#comment615>

    Another change undone



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/100369/#comment616>

    Why did you change this? Just passing ProtocolInfo looks much better.



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/100369/#comment617>

    Hmm, i think you forgot to merge with master



src/KCMTelepathyAccounts/parameter-edit-widget.cpp
<http://git.reviewboard.kde.org/r/100369/#comment618>

    Again, this should stay



src/accounts-list-model.cpp
<http://git.reviewboard.kde.org/r/100369/#comment612>

    Why did you add this? There should not be a possibility that accounts get deleted without removing them from the model right?



src/kcm-telepathy-accounts.h
<http://git.reviewboard.kde.org/r/100369/#comment613>

    You undid my change here to use pointers instead of multiple inheritance



src/kcm-telepathy-accounts.cpp
<http://git.reviewboard.kde.org/r/100369/#comment614>

    The name seems a little unfortunate to me, as you're actually changing the data in the model


- Thomas


On Jan. 12, 2011, 1:14 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100369/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2011, 1:14 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Added 3 new roles to the account model. Connection as a string (online, connecting, disconnected), and as an icon.
> Also added a string which says why the user is offline.
> (because the account is disabled, because the password is wrong, network error etc)
> 
> Then created an Item Delegate for the accounts view that looks pretty.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6ebed1268e697b9816ac0620467605c71324b3ef 
>   src/KCMTelepathyAccounts/account-edit-widget.h 4c78338603dc0b88230b52190ca9d373dff2628d 
>   src/KCMTelepathyAccounts/account-edit-widget.cpp b554db71a17a4c9664d04f781561ce62cbc17562 
>   src/KCMTelepathyAccounts/account-edit-widget.ui 6387e2be80747b8721bef9934258d2d489cd8cac 
>   src/KCMTelepathyAccounts/parameter-edit-widget.cpp 187c39fbf990b610b8985d1869d48bc2be7c9c6d 
>   src/KCMTelepathyAccounts/parameter-edit-widget.ui 25a2453d5a85ebe3f646c28e7acdb728ca14f1fa 
>   src/KCMTelepathyAccounts/protocol-item.h 90b96ee4ac6f4185a74a4d197b47ee1830564a43 
>   src/KCMTelepathyAccounts/protocol-item.cpp 03ac0bceff0f32673a706329f698a66323842c69 
>   src/KCMTelepathyAccounts/protocol-select-widget.cpp fa4b3c6d49d2287b63ba64730e1ec034508e8c55 
>   src/account-item.h 75e24116c525e2315c9d8f622d3b2fcb1c5c1bb8 
>   src/account-item.cpp 50afaa54c96ad51b6775f954cc180d1e12bbe96b 
>   src/accounts-list-delegate.h PRE-CREATION 
>   src/accounts-list-delegate.cpp PRE-CREATION 
>   src/accounts-list-model.h 815719a08b1a3091d007a6ef30ab1131fd8b489c 
>   src/accounts-list-model.cpp e0cf9bd13c7f1af8e8d936fe3e66af6db3aefdbc 
>   src/add-account-assistant.cpp 3933763957b1448aacf9e6c7efbc6b296a5e3664 
>   src/edit-account-dialog.cpp 73462f2e2a93e22e6d5d67297c575f4e10d44c5c 
>   src/kcm-telepathy-accounts.h 513db22457c2b77b4e36d54689d3b16810ac6854 
>   src/kcm-telepathy-accounts.cpp c2579d2eb38c371f23e86f0a468f1ce90ef75b88 
>   src/main-widget.ui b8ad1e5e243f923240382eda22414347ae173907 
> 
> Diff: http://git.reviewboard.kde.org/r/100369/diff
> 
> 
> Testing
> -------
> 
> Opened concurrently in both empathy and the accounts KCM, checked online state changed correctly, and that the "enabled" flag worked.
> 
> Tried accounts with network errors and incorrect passwords.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/100369/s/42/
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110112/1720a686/attachment.htm