Review Request: Add convenience methods to map parameters and UI widgets

[Dominik Schmidt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100368/
-----------------------------------------------------------

(Updated Jan. 12, 2011, 1:02 a.m.)


Review request for Telepathy.


Summary (updated)
-------

The external API isn't changed, so there is no need to port any plugins.


Thomas Richard made a suggestion to use QDataWidgetMapper:
http://paste.kde.org/2311/

Tonight I'm too lazy and too tired to merge and test it :-)

It's looking more elegant at first sight (because we dont need to implement "setters" and "getters" for every widget type).


Diffs
-----

  src/KCMTelepathyAccounts/CMakeLists.txt 082f3352c4e5855d87b594620e7e317160b557c1 
  src/KCMTelepathyAccounts/abstract-account-parameters-widget.h 44bba673ee0479f7253e6c2ac0860888362d0642 
  src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp d0ad71a3660ed2514817a67e6fd2a283481b54d9 

Diff: http://git.reviewboard.kde.org/r/100368/diff


Testing
-------

I made my ICQ plugin use it and it works.

If I rename the password parameter to some bogus, the lineedit and the label are hidden.


Thanks,

Dominik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110112/85287791/attachment.htm