Review Request: Add missing consts

Thomas Richard thomas.richard at proan.be
Tue Jan 11 00:39:38 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100343/#review828
-----------------------------------------------------------

Ship it!


Looks good to me!

- Thomas


On Jan. 9, 2011, 10:17 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100343/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 10:17 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add some missing consts and pass by references to the account plugins.
> All the plugins will need updating.
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/abstract-account-parameters-widget.h 6357b4eaff3b5579b44d9040ffe33314bbf09d80 
>   src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp d0ad71a3660ed2514817a67e6fd2a283481b54d9 
>   src/KCMTelepathyAccounts/abstract-account-ui.h a90395ca4e429fa37ccf935f19fcd0063397d4e9 
>   src/KCMTelepathyAccounts/abstract-account-ui.cpp a2a09c0485e2eec5e64c96a91ddaddea2747e68d 
> 
> Diff: http://git.reviewboard.kde.org/r/100343/diff
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110110/d9e5fb02/attachment.html 


More information about the KDE-Telepathy mailing list