Review Request: Accounts KCM Idle/IRC configuration plugin

David Edmundson kde at davidedmundson.co.uk
Sun Jan 9 20:14:50 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100337/#review817
-----------------------------------------------------------

Ship it!


Looks good to me.


idle/idle-account-ui.cpp
<http://git.reviewboard.kde.org/r/100337/#comment601>

    These should be const references too.
    
    However, this isn't your fault. It's the library which is wrong.



idle/idle-account-ui.cpp
<http://git.reviewboard.kde.org/r/100337/#comment602>

    Same as above.


- David


On Jan. 9, 2011, 5:36 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100337/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 5:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> A way to select an IRC network from a set of presets isn't yet done. Does Telepathy give anything here?
> 
> Also there isn't any hint for the user what "Username" means. I'm still wondering if it being empty means "use current local system username as one" or "use nick as one" and a set value to use that value as one. I guess it should default to empty anyhow. Empathy doesn't seem to use the parameter in any way.
> 
> There isn't an error message shown if parameter validation fails, but it wouldn't even show if someone does "Enable/Disable the "next" (or finish button) depending on whether required parameters are filled in." (as at http://community.kde.org/index.php?title=Real-Time_Communication_and_Collaboration/Components/Accounts_KCM_Tasks ).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4a102d94a28c5ac927039ed63acc10c08b490ad4 
>   idle/CMakeLists.txt PRE-CREATION 
>   idle/Messages.sh PRE-CREATION 
>   idle/advanced-options-widget.h PRE-CREATION 
>   idle/advanced-options-widget.cpp PRE-CREATION 
>   idle/advanced-options-widget.ui PRE-CREATION 
>   idle/idle-account-ui-plugin.h PRE-CREATION 
>   idle/idle-account-ui-plugin.cpp PRE-CREATION 
>   idle/idle-account-ui.h PRE-CREATION 
>   idle/idle-account-ui.cpp PRE-CREATION 
>   idle/kcmtelepathyaccounts_plugin_idle.desktop PRE-CREATION 
>   idle/main-options-widget.h PRE-CREATION 
>   idle/main-options-widget.cpp PRE-CREATION 
>   idle/main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100337/diff
> 
> 
> Testing
> -------
> 
> It compiles and the plugin loads.
> Tested creating and editing an account. All supported parameters load and save correctly and Empathy can use the created account.
> Validation (just testing if server and nick are non-empty) works.
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110109/bd476951/attachment.htm 


More information about the KDE-Telepathy mailing list