Review Request: Remove double margins and some more UI fixes

Thomas Richard thomas.richard at proan.be
Sun Jan 9 17:09:44 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100334/
-----------------------------------------------------------

(Updated Jan. 9, 2011, 4:09 p.m.)


Review request for Telepathy.


Changes
-------

Implemented David's suggestions and made the use of Ui files consistent within this module


Summary
-------

Remove some double margins and get rid of the advanced button if it's not needed. Up until now it was just eating up space.

The ParameterEditWidget also scales as it supposed to again.


Diffs (updated)
-----

  src/KCMTelepathyAccounts/account-edit-widget.cpp b2afd2fd4e4803cd5babcc69ea52d29d7c572b6d 
  src/KCMTelepathyAccounts/account-edit-widget.ui 6387e2be80747b8721bef9934258d2d489cd8cac 
  src/KCMTelepathyAccounts/parameter-edit-widget.cpp 9d071e32bfba53f62272899cad32925c111a193f 
  src/KCMTelepathyAccounts/parameter-edit-widget.ui 25a2453d5a85ebe3f646c28e7acdb728ca14f1fa 
  src/KCMTelepathyAccounts/protocol-select-widget.cpp fa4b3c6d49d2287b63ba64730e1ec034508e8c55 
  src/edit-account-dialog.cpp 27b0e73d8dff4ff1767eba6d4cd274b3758cf6e8 
  src/kcm-telepathy-accounts.h 9ea44c32894ce6b85d0b8a42418e7b3b0fbca425 
  src/kcm-telepathy-accounts.cpp 83550b86b25186bd2bce22b0e25432a2b3e9b009 
  src/main-widget.ui b8ad1e5e243f923240382eda22414347ae173907 

Diff: http://git.reviewboard.kde.org/r/100334/diff


Testing
-------

Compile + looking at the GUI


Thanks,

Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110109/38f09696/attachment.htm 


More information about the KDE-Telepathy mailing list