Review Request: Remove double margins and some more UI fixes

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100334/#review804
-----------------------------------------------------------



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/100334/#comment594>

    This gets leaked. If you want to change it to a pointer, make sure you delete it in the destructor of AccountEditWidget



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/100334/#comment595>

    Doesn't look like d gets deleted either (not your fault, but still looks wrong)



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/100334/#comment596>

    KDE policy is to always include braces
    if () {
    
    }
    
    



src/KCMTelepathyAccounts/account-edit-widget.cpp
<http://git.reviewboard.kde.org/r/100334/#comment597>

    I'm pretty sure setVisible(false) means the widget doesn't take any space. I don't think you should be deleting objects where we don't have to. 


- David


On Jan. 9, 2011, 10:24 a.m., Thomas Richard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100334/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 10:24 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Remove some double margins and get rid of the advanced button if it's not needed. Up until now it was just eating up space.
> 
> The ParameterEditWidget also scales as it supposed to again.
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/account-edit-widget.h 8724820d06693a93c46231681d552508c7f16231 
>   src/KCMTelepathyAccounts/account-edit-widget.cpp b2afd2fd4e4803cd5babcc69ea52d29d7c572b6d 
>   src/KCMTelepathyAccounts/account-edit-widget.ui 6387e2be80747b8721bef9934258d2d489cd8cac 
>   src/KCMTelepathyAccounts/parameter-edit-widget.ui 25a2453d5a85ebe3f646c28e7acdb728ca14f1fa 
>   src/edit-account-dialog.cpp 27b0e73d8dff4ff1767eba6d4cd274b3758cf6e8 
> 
> Diff: http://git.reviewboard.kde.org/r/100334/diff
> 
> 
> Testing
> -------
> 
> Compile + looking at the GUI
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110109/42faa678/attachment-0001.htm