Review Request: Slight refactor + UI tidy.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100325/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Refactor AccountEditWidget to pass ProtocolInfo rather than several QStrings seperately.
This simplifies bits of code and reduces the chance of sending garbage data to the account edit widget. Also gives the account edit access to the protocol icon for a UI tidyup.


Diffs
-----

  src/KCMTelepathyAccounts/account-edit-widget.h 4c78338603dc0b88230b52190ca9d373dff2628d 
  src/KCMTelepathyAccounts/account-edit-widget.cpp b554db71a17a4c9664d04f781561ce62cbc17562 
  src/KCMTelepathyAccounts/account-edit-widget.ui 6387e2be80747b8721bef9934258d2d489cd8cac 
  src/KCMTelepathyAccounts/protocol-item.h 90b96ee4ac6f4185a74a4d197b47ee1830564a43 
  src/KCMTelepathyAccounts/protocol-item.cpp 03ac0bceff0f32673a706329f698a66323842c69 
  src/add-account-assistant.cpp 3933763957b1448aacf9e6c7efbc6b296a5e3664 
  src/edit-account-dialog.cpp 73462f2e2a93e22e6d5d67297c575f4e10d44c5c 

Diff: http://git.reviewboard.kde.org/r/100325/diff


Testing
-------

Compiled, loaded, clicked both add+edit. Both seemed to still be ok.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110108/9a03f5d8/attachment.htm