Review Request: Update Tp Account Plugins

David Edmundson kde at davidedmundson.co.uk
Thu Jan 6 03:28:06 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100297/
-----------------------------------------------------------

(Updated 2011-01-06 02:28:06.145765)


Review request for Telepathy.


Changes
-------

Moved to latest KCMAccounts lib. Fixed all consts as noted last review.


Summary
-------

Updated the plugins to match changes in http://git.reviewboard.kde.org/r/100293/


Self review: has the same 'const' issues as the review mentioned above.


Diffs (updated)
-----

  butterfly/main-options-widget.h fb2d2f6363641a143f9b1bf4fe5b3d0b0c8fa20b 
  butterfly/main-options-widget.cpp 56813c05e25ffdc4dcfd98bc1f8e2e0a93229649 
  gabble/advanced-options-widget.h 2c6ce63ecb4e46be34b59c8ed520ca4117e54421 
  gabble/advanced-options-widget.cpp fe69fd5d1278706af77679f345124e6d1d49ebe2 
  gabble/main-options-widget.h d66725d59f4dd9956c73352fb02a21368b338e51 
  gabble/main-options-widget.cpp 97fe5aa3611e1d564a1f768e65be2fe57ff3d258 
  gabble/proxy-settings-widget.h ef064ed21885d88467791eea42b316593869e9ea 
  gabble/proxy-settings-widget.cpp fb4302f79ce95ddaa24991af6ee039459411b450 
  gabble/proxy-settings-widget.ui 418ca7568f63595a3a6f93f9e96addcbbe15d30e 
  gabble/server-settings-widget.h 19d414ec6185354a7d11aa2063a07c381e40fa2a 
  gabble/server-settings-widget.cpp d484ca39982db3217fbfd2a40a2d6640b5099d66 
  gabble/server-settings-widget.ui 12fadbcfb29da75281bc60b70acb60cf5ac68a5f 

Diff: http://git.reviewboard.kde.org/r/100297/diff


Testing
-------

Edited an account in each protocol, checked parameters updated.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110106/7ee81017/attachment.htm 


More information about the KDE-Telepathy mailing list