Review Request: Make use of AccountFactory

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100295/#review715
-----------------------------------------------------------

Ship it!


Just one minor annoyance - otherwise seems fine to me, even though I'm not really into this code - you might want to wait for at least another (even superficial) review.


src/accounts-list-model.cpp
<http://git.reviewboard.kde.org/r/100295/#comment533>

    please use kDebug here


- Dario


On 2011-01-03 20:22:53, David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100295/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 20:22:53)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Make use of AccountFactory
> This reduces the complexity of the account list model as it no longer needs to maintain two lists for ready and unready accounts.
> 
> 
> Diffs
> -----
> 
>   src/account-item.h 75e24116c525e2315c9d8f622d3b2fcb1c5c1bb8 
>   src/account-item.cpp 50afaa54c96ad51b6775f954cc180d1e12bbe96b 
>   src/accounts-list-model.h 815719a08b1a3091d007a6ef30ab1131fd8b489c 
>   src/accounts-list-model.cpp e0cf9bd13c7f1af8e8d936fe3e66af6db3aefdbc 
>   src/kcm-telepathy-accounts.h 513db22457c2b77b4e36d54689d3b16810ac6854 
>   src/kcm-telepathy-accounts.cpp c2579d2eb38c371f23e86f0a468f1ce90ef75b88 
> 
> Diff: http://git.reviewboard.kde.org/r/100295/diff
> 
> 
> Testing
> -------
> 
> Added an account, removed one.
> Even added/removed accounts from empathy whilst this was running and it all worked as expecting.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110103/f34c24fd/attachment.htm