Review Request: plugin for the sunshine connection manager: provides gadu-gadu

[Florian Reinhard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100693/
-----------------------------------------------------------

(Updated Feb. 27, 2011, 2:47 p.m.)


Review request for Telepathy.


Changes
-------

* new strings in advanced->misc settings
* comments cleanup
* use QLatin1String
* add comment for upcoming parameter name change (tp-sunshine 0.1.8 vs master)


Summary
-------

This patch adds a plugin for the telepathy-sunshine connection manager which provides gadu-gadu support.


Diffs (updated)
-----

  sunshine/sunshine-main-options-widget.ui PRE-CREATION 
  sunshine/sunshine-main-options-widget.cpp PRE-CREATION 
  sunshine/sunshine-main-options-widget.h PRE-CREATION 
  sunshine/sunshine-advanced-options-widget.cpp PRE-CREATION 
  sunshine/sunshine-advanced-options-widget.ui PRE-CREATION 
  sunshine/sunshine-advanced-options-widget.h PRE-CREATION 
  sunshine/sunshine-account-ui.h PRE-CREATION 
  sunshine/sunshine-account-ui.cpp PRE-CREATION 
  sunshine/sunshine-account-ui-plugin.cpp PRE-CREATION 
  sunshine/sunshine-account-ui-plugin.h PRE-CREATION 
  CMakeLists.txt af2208973bc096cb4c572fa807adbcd79250a3bd 
  sunshine/CMakeLists.txt PRE-CREATION 
  sunshine/Messages.sh PRE-CREATION 
  sunshine/kcmtelepathyaccounts_plugin_sunshine.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100693/diff


Testing
-------

* add account
* change account
* delete account
* check the above in empathy
* connect


Screenshots
-----------

Main and Advanced Settings
  http://git.reviewboard.kde.org/r/100693/s/78/
New strings for advanced->misc-settings
  http://git.reviewboard.kde.org/r/100693/s/86/


Thanks,

Florian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110227/b7fab88b/attachment.htm