Review Request: plugin for the sunshine connection manager: provides gadu-gadu

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100693/#review1586
-----------------------------------------------------------


Code looks fine, one UI comment.


Screenshot: Main and Advanced Settings
<http://git.reviewboard.kde.org//r/100693/#scomment4>
    You don't need labels if you're using QCheckbox, the text on the right is sufficient.
    
    Also I (as a user) don't understand what S(SSL) is. Is it just SSL?
    
    

- David


On Feb. 20, 2011, 6:47 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100693/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 6:47 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch adds a plugin for the telepathy-sunshine connection manager which provides gadu-gadu support.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f7fa03d 
>   sunshine/CMakeLists.txt PRE-CREATION 
>   sunshine/Messages.sh PRE-CREATION 
>   sunshine/kcmtelepathyaccounts_plugin_sunshine.desktop PRE-CREATION 
>   sunshine/sunshine-account-ui-plugin.h PRE-CREATION 
>   sunshine/sunshine-account-ui-plugin.cpp PRE-CREATION 
>   sunshine/sunshine-account-ui.h PRE-CREATION 
>   sunshine/sunshine-account-ui.cpp PRE-CREATION 
>   sunshine/sunshine-advanced-options-widget.h PRE-CREATION 
>   sunshine/sunshine-advanced-options-widget.cpp PRE-CREATION 
>   sunshine/sunshine-advanced-options-widget.ui PRE-CREATION 
>   sunshine/sunshine-main-options-widget.h PRE-CREATION 
>   sunshine/sunshine-main-options-widget.cpp PRE-CREATION 
>   sunshine/sunshine-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100693/diff
> 
> 
> Testing
> -------
> 
> * add account
> * change account
> * delete account
> * check the above in empathy
> * connect
> 
> 
> Screenshots
> -----------
> 
> Main and Advanced Settings
>   http://git.reviewboard.kde.org/r/100693/s/78/
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110222/68e79830/attachment.htm