Review Request: Add plugin for the salute connection manager which provides bonjour

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100712/#review1568
-----------------------------------------------------------


I'm so pleased someone wrote a plugin for this, thanks.

A few minor comments. 



salut/salut-account-ui-plugin.cpp
<http://git.reviewboard.kde.org/r/100712/#comment1354>

    if() {
     //brace on same line as the end of the 'if' statement.
    }
    
    also wrap the char*s in QLatin1String
    
    (connectionManager == QLatin1String("salut"))
    
    Reason: http://developer.qt.nokia.com/wiki/UsingQStringEffectively



salut/salut-account-ui-plugin.cpp
<http://git.reviewboard.kde.org/r/100712/#comment1356>

    I don't understand the part:
    or serviceName == "local_xmpp"
    
    No other protocol should have a profile called local_xmpp, and if it did it could be a completely different set of options that should go to a different UI plugin.



salut/salut-advanced-options-widget.ui
<http://git.reviewboard.kde.org/r/100712/#comment1355>

    If KSomeWidget exists, it's better to use it rather than QSomeWidget.
    
    These really should be KLineEdits.
    


- David


On Feb. 21, 2011, 11:05 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100712/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2011, 11:05 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add plugin for the salute connection manager which provides bonjour.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f7fa03d93f0ba3fb460df9ab3342cb9e75bbe792 
>   salut/CMakeLists.txt PRE-CREATION 
>   salut/Messages.sh PRE-CREATION 
>   salut/kcmtelepathyaccounts_plugin_salut.desktop PRE-CREATION 
>   salut/salut-account-ui-plugin.h PRE-CREATION 
>   salut/salut-account-ui-plugin.cpp PRE-CREATION 
>   salut/salut-account-ui.h PRE-CREATION 
>   salut/salut-account-ui.cpp PRE-CREATION 
>   salut/salut-advanced-options-widget.h PRE-CREATION 
>   salut/salut-advanced-options-widget.cpp PRE-CREATION 
>   salut/salut-advanced-options-widget.ui PRE-CREATION 
>   salut/salut-main-options-widget.h PRE-CREATION 
>   salut/salut-main-options-widget.cpp PRE-CREATION 
>   salut/salut-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100712/diff
> 
> 
> Testing
> -------
> 
> add account in empathy
> edit in kcm
> adding in kcm is currently not possible, is about to be fixed by David Edmundsen.
> 
> 
> Screenshots
> -----------
> 
> Main and Advanced Options
>   http://git.reviewboard.kde.org/r/100712/s/81/
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110221/377c4d1e/attachment.html