Review Request: replace KDE_EXPORT with KCM_TELEPATHY_ACCOUNTS_EXPORT

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100695/#review1554
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/100695/#comment1339>

    This should only be defined in src/KCMTelepathyAccounts/CMakeLists.txt, where the library is built. Everything else is just using this library.



src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/100695/#comment1338>

    No, this header should be in the src/KCMTelepathyAccounts/ directory and it should be installed in the same directory as the other headers, not in $prefix/include.


- George


On Feb. 21, 2011, 1:35 a.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100695/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2011, 1:35 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> replace KDE_EXPORT with KCM_TELEPATHY_ACCOUNTS_EXPORT
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5a2af5f5428596f52327932b4fa0603d163cb58f 
>   src/CMakeLists.txt c55c04622e177283007460d51593a39fccb07b55 
>   src/KCMTelepathyAccounts/abstract-account-parameters-widget.h 1e2d5b6c3d73fb4d3e123ce2dd0fe674abf16337 
>   src/KCMTelepathyAccounts/abstract-account-ui-plugin.h ee095f2d7e0b3c28cc0c08b04c28bf2a544e9c1a 
>   src/KCMTelepathyAccounts/abstract-account-ui.h c158ea5400bbf940008feea41a1951aa6eaf93b0 
>   src/KCMTelepathyAccounts/account-edit-widget.h e365195b8b297b283a4609de52049b87215f18e5 
>   src/KCMTelepathyAccounts/generic-advanced-options-widget.h b1bca8a85d7b2175eac62d04eea710cd5b017f03 
>   src/KCMTelepathyAccounts/parameter-edit-model.h 145fc22b4dcf688533fdde6f4333f15f46b1ce89 
>   src/KCMTelepathyAccounts/parameter-edit-widget.h 4e48478e190ee3f44196275a7a517d896fe3d53a 
>   src/KCMTelepathyAccounts/plugin-manager.h 6ac4df6b29d573af0502e3d9a9f976bd1ce0500d 
>   src/KCMTelepathyAccounts/profile-item.h 41a030fff57e722a4587505317c0b8c45ccd16d3 
>   src/KCMTelepathyAccounts/profile-select-widget.h 3f741f0aab9ab4f24d3b2a52347e2e68d5152f71 
>   src/KCMTelepathyAccounts/unsigned-integer-edit.h 6ccf16c5135b2266102db360e12a5904e331fdb3 
>   src/edit-account-dialog.h a5c0270e35ad26df20b1fb446060e0b75e82cecd 
>   src/kcm_telepathy_accounts_export.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100695/diff
> 
> 
> Testing
> -------
> 
> compiled and installed telepath-accpunts-kcm
> compiled and installed telepath-accpunts-kcm-plugins
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110221/292f0677/attachment.htm