Review Request: Refactor libtelepathy-kde-call, the audio/video streaming library of the call ui.

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100687/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

This is a complete refactoring of libtelepathy-kde-call, the library that handles audio/video streaming using telepathy-farstream.

The new design is based on the new Call.DRAFT spec and telepathy-farstream, which are way cleaner than their predecessors, StreamedMediaChannel and telepathy-farsight. This inherently makes the design of this library cleaner too. In addition to this, the GStreamer sources and sinks have also been redesigned to handle correctly possible race conditions (i.e. do correct synchronization between the main thread and the gstreamer streaming threads and also between telepathy-qt4 and telepathy-glib) and also allow dynamic switching of source devices.

http://quickgit.kde.org/?p=clones/telepathy-call-ui/gkiagia/telepathy-call-ui.git&a=shortlog&h=refs/heads/call-2


Diffs
-----

  CMakeLists.txt 59582bfa98fd738e50a5efbb39d03802e9f0e25c 
  libqtf/CMakeLists.txt PRE-CREATION 
  libqtf/qtf.h PRE-CREATION 
  libqtf/qtf.cpp PRE-CREATION 
  libtelepathy-kde-call/CMakeLists.txt d6a39b8d182f457909a78bf9a02a0d0efbf1aceb 
  libtelepathy-kde-call/callchannelhandler.h 94c27c18a1c37f590232acd9c9a77a969f85bedd 
  libtelepathy-kde-call/callchannelhandler.cpp 05aeff6040bb741a61b08ff1520e002487903406 
  libtelepathy-kde-call/callchannelhandler_p.h 5a1ce85bee81ef0e3c088e22845537e9c60c62f0 
  libtelepathy-kde-call/callcontenthandler.h PRE-CREATION 
  libtelepathy-kde-call/callcontenthandler.cpp PRE-CREATION 
  libtelepathy-kde-call/callcontenthandler_p.h PRE-CREATION 
  libtelepathy-kde-call/callparticipant.h 5ac2ad7d69e5465f18f25de0c86b8333ee632af3 
  libtelepathy-kde-call/callparticipant.cpp 9a683935d1212262671b6bab071b179b70dacb5b 
  libtelepathy-kde-call/sinkcontrollers.h PRE-CREATION 
  libtelepathy-kde-call/sinkcontrollers.cpp PRE-CREATION 
  libtelepathy-kde-call/sinkcontrollers_p.h PRE-CREATION 
  libtelepathy-kde-call/sourcecontrollers.h PRE-CREATION 
  libtelepathy-kde-call/sourcecontrollers.cpp PRE-CREATION 
  libtelepathy-kde-call/sourcecontrollers_p.h PRE-CREATION 
  libtelepathy-kde-call/tests/CMakeLists.txt PRE-CREATION 
  libtelepathy-kde-call/tests/sourcetest.cpp PRE-CREATION 
  libtelepathy-kde-call/volumecontroller.h PRE-CREATION 
  libtelepathy-kde-call/volumecontroller.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100687/diff


Testing
-------

I have successfully done audio calls with call-ui <-> empathy and call-ui <-> echo bot, using a modified version of the GUI that will be in another review request later, once it is completed. Video calls and some other features are not tested, as the GUI still needs some work to support them.


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110219/bd8ffecb/attachment-0001.htm