Integrating TP-Logger with KDE

[Olli Salli]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 18.02.2011 01:18, Daniele E. Domenichelli wrote:
> On 02/17/2011 08:26 PM, George Kiagiadakis wrote:
>> On Thu, Feb 17, 2011 at 7:23 PM, Stefano Sanfilippo
>> <stefano.k.sanfilippo at gmail.com> wrote:
>>> I've placed everything under a Tp::Logger namespace... Tell me whether it's
>>> good, or should I follow a different naming convention ;)
>>
>> I'd suggest to avoid namespace Tp. It is reserved by telepathy-qt4.
> 
> 
> The library uses "KTelepathy" (if it wasn't changed), so maybe
> KTelepathy::Logger could be ok?

If the lib isn't KDE specific (which I think it shouldn't be - I think
it can be generic Qt just fine - just keep the UI parts in an another
lib/app), I wouldn't put it in the KTelepathy ns. My 2 cents would be
Tpl:: as the corresponding glib library has the tpl_ prefix.

> 
> Do we have any other namespace naming convention?
> 
> Maybe we should choose one...
> We could rename KTelepathy to something shorter like KTp, TpK, TpKDE, or
> even Tp::KDE (if everything is inside a single sub-namespace KDE there
> should be no problem in using Tp) and use a sub-namespace for every
> component...

Please, not Tp::KDE. I think namespaces should be "reverse domain"
style, so Tp::KDE would mean "the KDE part of telepathy-qt4", not "the
Telepathy part of KDE". So KDE::Tp:: instead? Or KDETp::, if that's too
long? KTp appears a bit awkward to me.

> 
> 
> Cheers,
>  Daniele
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNXin6AAoJEAQQkupGanj4Wa8IAMFlbnB875M5PlWjhfvxcy5M
PeRIyHkwWhOy7yc7YHb2KugYuba9pVt59KNTUPpGBbwzNjyt1G22EVJ19nOZz0kb
tOTEB15ooNB62lJcx3AYTnoJrIYT27uYNAF+9lC7ixBNVPoubTq6gv9gza8dVbEm
6A0zf6jyCEiusTr8k8KiftWI2UsO2ZTYVKKjnCS2hDJrPTkXgA7937OYk01EIspw
p2j/RpFz2orBgnHyanTpaFQyzs0WmZmY0YaMLhi+OTdNtOmk8JL4EReQQ09Afe5h
3VsCslRtvgwhrW51rlWc8gSBuyTxzcpkZ0J0NPHOh2h4CIvX7Z3ylA+kFluvZgs=
=9eWN
-----END PGP SIGNATURE-----