Review Request: remove useless private classes, cleanup headers

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100667/#review1457
-----------------------------------------------------------

Ship it!


Looks good


gabble/main-options-widget.h
<http://git.reviewboard.kde.org/r/100667/#comment1218>

    Accidental trailing space inserted here. Remove it.


- George


On Feb. 16, 2011, 2:55 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100667/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2011, 2:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> remove useless private classes, cleanup headers
> 
> 
> Diffs
> -----
> 
>   butterfly/butterfly-account-ui-plugin.h 8c027d56d092b907348129a1211a7f7fca3b4436 
>   butterfly/butterfly-account-ui-plugin.cpp 5efa8afc18563697c8b19d51ab352b40289a010b 
>   butterfly/butterfly-account-ui.h 248f9467bc27dd0a277d177f66853419d5328f9a 
>   butterfly/butterfly-account-ui.cpp 67fc5f788bbee68a1c736da834cc9a98e2b13ee8 
>   butterfly/main-options-widget.h ec7ca343f8de5ececba4194138fb05f9040ac4e5 
>   butterfly/main-options-widget.cpp e8c5717545e35489ad37befd78c9772c6ae6b54a 
>   gabble/gabble-account-ui-plugin.h 76de025c15cb82cc98abbb7093fc75fc9b92ee90 
>   gabble/gabble-account-ui-plugin.cpp ae9f79a4f702c7b17ba75b1a09209a2b27783bca 
>   gabble/gabble-account-ui.h 2b828e31cac68444f45feed6ff2a1c20de016a1b 
>   gabble/gabble-account-ui.cpp 4a1ea987115ccfab42927cb1eccd36669b6ad658 
>   gabble/main-options-widget.h 7b04473b00c87370082f86e90c673207bf0b8fe2 
>   gabble/main-options-widget.cpp 333e0b49f0043491115b3adf6a25fd7ce22c8585 
>   gabble/proxy-settings-widget.h 55777a76f80c9f1475888b24be6ef85bb58b3b63 
>   gabble/proxy-settings-widget.cpp f68fe36877e8c684435c8d106177343804fe237e 
>   gabble/server-settings-widget.h 504797eb8820a0da8d7c34f13494d94950aa83e2 
>   gabble/server-settings-widget.cpp 9bc2fe285a6eceaa27d023d983c2cfce429339d4 
>   haze/haze-account-ui-plugin.h 28d7b430bff59bc28d22021fa44c8f213fb70469 
>   haze/haze-account-ui-plugin.cpp 2e5a386da637ac2fb390d33cbbd15137e7e44742 
>   haze/haze-icq-account.h d90c7898751237d9f60a74530f4b40922c995c18 
>   haze/haze-icq-account.cpp 5bc662a44f06a195929b4a2eee78a7dc667290ad 
>   haze/haze-yahoo-account.h 1f94f44e0a4fd2d689e0f4f9d80ba7a8b2ffd20b 
>   haze/haze-yahoo-account.cpp 96fda32f1390f2e1c91bafbfbdf187f426d7edcb 
>   haze/icq-main-options-widget.h ffe340b9d2e838138756519de1f0c83b8e3a7e0f 
>   haze/icq-main-options-widget.cpp 3faa1af9aec25ce5b4cc9ecb0465b033aa16f3a0 
>   haze/icq-server-settings-widget.h 6353269c36a338477c3cf8799b2efbe89cbebbf9 
>   haze/icq-server-settings-widget.cpp 3d08d50d471c0bda0b39c71ca2d780578466a490 
>   haze/yahoo-main-options-widget.h a694145ec6d26930c80aaf737d84f8f16569a624 
>   haze/yahoo-main-options-widget.cpp 10501eb6301a470a6ddac7b06f816334d226b0a0 
>   idle/advanced-options-widget.h 4ff2cc0e8e9e1b3c51b15e11d9385ca376f2364c 
>   idle/advanced-options-widget.cpp 295d8c12ec26c83841e9967b0dcc0a8fce603125 
>   idle/idle-account-ui-plugin.h 98eaf4e732791ae144a7b55801a88c6c7ddcc58f 
>   idle/idle-account-ui-plugin.cpp 87aca1715ceb0636d955e0f2e26bf70f36e55be1 
>   idle/idle-account-ui.h fa6516777c6cd564fbdeffd97a3e99bea0fc56cf 
>   idle/idle-account-ui.cpp 7db617649534be1b496e81bdcede28752056ebdc 
>   idle/main-options-widget.h 513d37243e0e5bc904a0f4f467d4408f8599a584 
>   idle/main-options-widget.cpp 2bcc600cd837d5b59ed72966406e28f32500c06e 
>   rakia/rakia-account-ui-plugin.cpp 9a09052ca1ed71d7a25c38999ec7dd1cdd68ab4a 
>   rakia/rakia-account-ui.cpp 97c78422506a6ee56a72b9537168d48f53c082bb 
>   rakia/rakia-advanced-options-widget.h 0b619d400da7ea4168077dd41c15936c6988d0c7 
>   rakia/rakia-advanced-options-widget.cpp c6fa94ab360c06ec4f50e6740c9941f62b112a6a 
>   rakia/rakia-main-options-widget.h efcc07a719a3a7e90f137c194a047b229f83eadd 
> 
> Diff: http://git.reviewboard.kde.org/r/100667/diff
> 
> 
> Testing
> -------
> 
> compiles, dialogs open.
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110216/b09292df/attachment.htm