Review Request: rakia plugin for telepathy-accounts-kcm

[Florian Reinhard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100444/
-----------------------------------------------------------

(Updated Feb. 16, 2011, 12:04 p.m.)


Review request for Telepathy.


Changes
-------

* remove private classes
* fix whitespace issues
* fix linelength issues
* reformat ugly comments
* reformat code using astyle


Summary
-------

the following telepathy-sofiasip parameters are implemented:
account
password
alias

auth-user
registrar

proxy-host
port
transport

discover-stun
stun-server
stun-port

discover-binding
loose-routing
keepalive-mechanism
keepalive-interval


these are missing atm:
immutable-streams
local-ip-address
local-port
extra-auth-user
extra-auth-password


Diffs (updated)
-----

  CMakeLists.txt 9aec0ecf2243e302d3cd01f1c4bd246f6e248305 
  rakia/CMakeLists.txt PRE-CREATION 
  rakia/Messages.sh PRE-CREATION 
  rakia/kcmtelepathyaccounts_plugin_rakia.desktop PRE-CREATION 
  rakia/rakia-account-ui-plugin.h PRE-CREATION 
  rakia/rakia-account-ui-plugin.cpp PRE-CREATION 
  rakia/rakia-account-ui.h PRE-CREATION 
  rakia/rakia-account-ui.cpp PRE-CREATION 
  rakia/rakia-advanced-options-widget.h PRE-CREATION 
  rakia/rakia-advanced-options-widget.cpp PRE-CREATION 
  rakia/rakia-advanced-options-widget.ui PRE-CREATION 
  rakia/rakia-main-options-widget.h PRE-CREATION 
  rakia/rakia-main-options-widget.cpp PRE-CREATION 
  rakia/rakia-main-options-widget.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100444/diff


Testing
-------

add new account
edit existing account
connect


Screenshots
-----------

Main Options and Advanced Options
  http://git.reviewboard.kde.org/r/100444/s/55/
as implemented in diff r3
  http://git.reviewboard.kde.org/r/100444/s/76/


Thanks,

Florian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110216/c14688de/attachment.htm