Review Request: rakia plugin for telepathy-accounts-kcm

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100444/#review1445
-----------------------------------------------------------


The code itself looks fine.

There's a few whitespace issues, you could possibly just pass your code through this: 
http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_.28astyle.29_automatic_code_formatting

The private classes which only contain a pointer to the UI are a bit pointless, I imagine you just copied them from somewhere else. All the plugins seem to have this, I think it's leftover from before a refactor. Leave yours in if you like, and I'll tidy up all of the plugins together.


rakia/rakia-account-ui-plugin.cpp
<http://git.reviewboard.kde.org/r/100444/#comment1201>

    put a comment explaining why you're handling two CMs. A future coder won't have your review comments to refer to.
    



rakia/rakia-account-ui.cpp
<http://git.reviewboard.kde.org/r/100444/#comment1200>

    Not much point using the GenericAdvancedOptionsWidget if you only have one tab.
    
    You can always add it if/when you need it. (it's only two lines)



rakia/rakia-advanced-options-widget.cpp
<http://git.reviewboard.kde.org/r/100444/#comment1202>

    We don't really need a private class.
    
    As we're not part of a library here we can have as many member variables as we like
    (such as m_ui).


- David


On Feb. 13, 2011, 5:35 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100444/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2011, 5:35 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> the following telepathy-sofiasip parameters are implemented:
> account
> password
> alias
> 
> auth-user
> registrar
> 
> proxy-host
> port
> transport
> 
> discover-stun
> stun-server
> stun-port
> 
> discover-binding
> loose-routing
> keepalive-mechanism
> keepalive-interval
> 
> 
> these are missing atm:
> immutable-streams
> local-ip-address
> local-port
> extra-auth-user
> extra-auth-password
> 
> 
> Diffs
> -----
> 
>   rakia/rakia-account-ui.h PRE-CREATION 
>   rakia/kcmtelepathyaccounts_plugin_rakia.desktop PRE-CREATION 
>   rakia/rakia-account-ui-plugin.h PRE-CREATION 
>   rakia/rakia-account-ui-plugin.cpp PRE-CREATION 
>   rakia/Messages.sh PRE-CREATION 
>   CMakeLists.txt 9aec0ecf2243e302d3cd01f1c4bd246f6e248305 
>   rakia/CMakeLists.txt PRE-CREATION 
>   rakia/rakia-account-ui.cpp PRE-CREATION 
>   rakia/rakia-advanced-options-widget.h PRE-CREATION 
>   rakia/rakia-advanced-options-widget.cpp PRE-CREATION 
>   rakia/rakia-advanced-options-widget.ui PRE-CREATION 
>   rakia/rakia-main-options-widget.h PRE-CREATION 
>   rakia/rakia-main-options-widget.cpp PRE-CREATION 
>   rakia/rakia-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100444/diff
> 
> 
> Testing
> -------
> 
> add new account
> edit existing account
> connect
> 
> 
> Screenshots
> -----------
> 
> Main Options and Advanced Options
>   http://git.reviewboard.kde.org/r/100444/s/55/
> as implemented in diff r3
>   http://git.reviewboard.kde.org/r/100444/s/76/
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110215/f10701df/attachment.htm