Review Request: Created haze-yahoo main options

Lasath Fernando kde at lasath.org
Sat Feb 12 02:57:21 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100633/
-----------------------------------------------------------

(Updated Feb. 12, 2011, 1:57 a.m.)


Review request for Telepathy.


Changes
-------

changed haze-icq-account-ui to haze-icq-account
updated header guard of haze-yahoo-account.h
wrote 0 instead of NULL

I made ~YahooMainOptionsWidget delete ui, but kept Private's destructor for redundancy. 


Summary
-------

I added the basic config for a Haze Yahoo account.


Diffs (updated)
-----

  haze/CMakeLists.txt da6e2ba 
  haze/haze-account-ui-plugin.cpp e684150 
  haze/haze-icq-account-ui.h bff28a4 
  haze/haze-icq-account-ui.cpp 98f3ce3 
  haze/haze-icq-account.h PRE-CREATION 
  haze/haze-icq-account.cpp PRE-CREATION 
  haze/haze-yahoo-account.h PRE-CREATION 
  haze/haze-yahoo-account.cpp PRE-CREATION 
  haze/yahoo-main-options-widget.h PRE-CREATION 
  haze/yahoo-main-options-widget.cpp PRE-CREATION 
  haze/yahoo-main-options-widget.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100633/diff


Testing
-------

Created an account, and checked to see if it appears in Empathy.


Thanks,

Lasath

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110212/42520fb4/attachment.htm 


More information about the KDE-Telepathy mailing list