Review Request: Created haze-yahoo main options

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100633/#review1375
-----------------------------------------------------------


Coding style nitpicking...


haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1122>

    Add a copyright here and DON'T use GPL 3. See KDE's licencing policy for details.



haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1124>

    Do you really need an empty private class?



haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1123>

    Remove extra space



haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1126>

    Too long line, split it in two. Try to keep lines below 100 columns.



haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1127>

    Also too long line.



haze/haze-yahoo-account.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1125>

    Remove the commented code. And keep a consistent coding style wrt to indentation level. Some code is with 4 spaces, some other with 2 spaces. I think the rest of the kcm is with 4 spaces, so please adjust to that.
    
    Please also adjust indentation level in all the other files. I am not going to put comments everywhere about that :)



haze/yahoo-main-options-widget.h
<http://git.reviewboard.kde.org/r/100633/#comment1128>

    Copyright & license please.



haze/yahoo-main-options-widget.h
<http://git.reviewboard.kde.org/r/100633/#comment1129>

    Remove extra space



haze/yahoo-main-options-widget.h
<http://git.reviewboard.kde.org/r/100633/#comment1132>

    Coding style: "public:" should start at column 0



haze/yahoo-main-options-widget.h
<http://git.reviewboard.kde.org/r/100633/#comment1130>

    Remove extra space



haze/yahoo-main-options-widget.h
<http://git.reviewboard.kde.org/r/100633/#comment1131>

    Remove extra space



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1133>

    Again, copyright & license



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1134>

    Remove extra space



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1139>

    This could also be allocated on the stack here to avoid new/delete, but well...



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1135>

    Remove extra space



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1136>

    Remove extra space



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1137>

    Remove extra space



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1138>

    Remove extra space


- George


On Feb. 12, 2011, 2:13 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100633/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2011, 2:13 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> I added the basic config for a Haze Yahoo account.
> 
> 
> Diffs
> -----
> 
>   haze/CMakeLists.txt da6e2ba 
>   haze/haze-account-ui-plugin.cpp e684150 
>   haze/haze-icq-account-ui.h bff28a4 
>   haze/haze-icq-account-ui.cpp 98f3ce3 
>   haze/haze-icq-account.h PRE-CREATION 
>   haze/haze-icq-account.cpp PRE-CREATION 
>   haze/haze-yahoo-account.h PRE-CREATION 
>   haze/haze-yahoo-account.cpp PRE-CREATION 
>   haze/yahoo-main-options-widget.h PRE-CREATION 
>   haze/yahoo-main-options-widget.cpp PRE-CREATION 
>   haze/yahoo-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100633/diff
> 
> 
> Testing
> -------
> 
> Created an account, and checked to see if it appears in Empathy.
> 
> 
> Thanks,
> 
> Lasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110212/bedb34be/attachment-0001.htm