Review Request: Created haze-yahoo main options

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100633/#review1370
-----------------------------------------------------------


A damn good first effort, few minor comments.


haze/CMakeLists.txt
<http://git.reviewboard.kde.org/r/100633/#comment1117>

    I don't like that we have a naming inconsistency
    
    haze-icq-account-ui
    and 
    haze-yahoo-account
    
    You should either gain "-ui", or ICQ should lose it.



haze/haze-yahoo-account.h
<http://git.reviewboard.kde.org/r/100633/#comment1118>

    The header guard should match the filename.
    
    Your filename doesn't have ui in the name, so neither should your header guard.



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1120>

    we tend to write 0 instead of NULL.



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100633/#comment1119>

    I normally go with the rule:
    
     Whoever created an object (ran "new FooBar()") is in charge of deleting it (unless there's a clear reason not to).
    
    It makes it a bit easier to pair everything up.
    
    which puts the deletion into ~YahooMainOptionsWidget. 


- David


On Feb. 12, 2011, 1:14 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100633/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2011, 1:14 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> I added the basic config for a Haze Yahoo account.
> 
> 
> Diffs
> -----
> 
>   haze/CMakeLists.txt da6e2ba 
>   haze/haze-account-ui-plugin.cpp e684150 
>   haze/haze-yahoo-account.h PRE-CREATION 
>   haze/haze-yahoo-account.cpp PRE-CREATION 
>   haze/yahoo-main-options-widget.h PRE-CREATION 
>   haze/yahoo-main-options-widget.cpp PRE-CREATION 
>   haze/yahoo-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100633/diff
> 
> 
> Testing
> -------
> 
> Created an account, and checked to see if it appears in Empathy.
> 
> 
> Thanks,
> 
> Lasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110212/258c8af0/attachment-0001.htm