Review Request: Add notifications configure dialog and fix linking

[Dominik Schmidt]

> On Feb. 6, 2011, 9:35 p.m., George Kiagiadakis wrote:
> > app/main.cpp, line 35
> > <http://git.reviewboard.kde.org/r/100587/diff/1/?file=8571#file8571line35>
> >
> >     I disagree with this change. The application's name should be "telepathy-kde-chat-ui", according to what we decided during the meeting. Why did you change it anyway?
> 
> Dominik Schmidt wrote:
>     To make the notifcations work and editable in the standard widget. If there is a cleaner solution, I'm happy to implement it that way.
> 
> David Edmundson wrote:
>     Knotification::setComponentData. 
>     
>     The chatWidget should does this already - I'm sure of it.

Yes, but that's not the solution and not the problem. :-)

KNotifyConfigWidget::configure(this, "ktelepathy"); <-- this works out


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100587/#review1272
-----------------------------------------------------------


On Feb. 6, 2011, 6:51 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100587/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2011, 6:51 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> In order to add the configure dialog I had to add a link target so I thought it was a good idea to do this in one rush:
> 
> See bug reports:
> 265420
> 265446
> 
> They should be fixed.
> 
> 
> Diffs
> -----
> 
>   adiumxtra-protocol-handler/CMakeLists.txt 514aa87 
>   app/CMakeLists.txt 738a3b6 
>   app/chatwindow.h e6e2ffd 
>   app/chatwindow.cpp 5cf2ea0 
>   app/main.cpp 06281e2 
>   lib/CMakeLists.txt f4e46aa 
> 
> Diff: http://git.reviewboard.kde.org/r/100587/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110207/6b1e8337/attachment-0001.htm