Review Request: Add notifications configure dialog and fix linking
George Kiagiadakis
kiagiadakis.george at gmail.com
Sun Feb 6 22:35:06 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100587/#review1272
-----------------------------------------------------------
app/main.cpp
<http://git.reviewboard.kde.org/r/100587/#comment1053>
I disagree with this change. The application's name should be "telepathy-kde-chat-ui", according to what we decided during the meeting. Why did you change it anyway?
- George
On Feb. 6, 2011, 6:51 p.m., Dominik Schmidt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100587/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2011, 6:51 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> In order to add the configure dialog I had to add a link target so I thought it was a good idea to do this in one rush:
>
> See bug reports:
> 265420
> 265446
>
> They should be fixed.
>
>
> Diffs
> -----
>
> adiumxtra-protocol-handler/CMakeLists.txt 514aa87
> app/CMakeLists.txt 738a3b6
> app/chatwindow.h e6e2ffd
> app/chatwindow.cpp 5cf2ea0
> app/main.cpp 06281e2
> lib/CMakeLists.txt f4e46aa
>
> Diff: http://git.reviewboard.kde.org/r/100587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110206/55dd03c2/attachment-0001.htm
More information about the KDE-Telepathy
mailing list