Review Request: ChatUi: Enable closing of tabs

Dominik Schmidt ich at dominik-schmidt.de
Fri Feb 4 18:00:31 CET 2011



> On Feb. 4, 2011, 3:38 p.m., George Kiagiadakis wrote:
> > app/mainwindow.cpp, line 117
> > <http://git.reviewboard.kde.org/r/100542/diff/1/?file=8351#file8351line117>
> >
> >     Shouldn't you also close the whole window here, or is this done automatically?

I've done that in a later revision


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100542/#review1220
-----------------------------------------------------------


On Feb. 4, 2011, 12:14 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100542/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 12:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Enable closing of tabs
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.cpp 54ac071 
> 
> Diff: http://git.reviewboard.kde.org/r/100542/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110204/ecd9321d/attachment.htm 


More information about the KDE-Telepathy mailing list