Review Request: ChatUi: Hide tabs until there is more than one tab in a window

Dominik Schmidt ich at dominik-schmidt.de
Fri Feb 4 15:03:24 CET 2011



> On Feb. 4, 2011, 1:21 p.m., David Edmundson wrote:
> > app/chatwindow.cpp, line 74
> > <http://git.reviewboard.kde.org/r/100554/diff/1/?file=8375#file8375line74>
> >
> >     do you want the tab bar re-disappear if you have 2 tabs and remove one? 
> >     
> >     If so you need to copy this code into removeTab.

Nice idea, sounds good.


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100554/#review1207
-----------------------------------------------------------


On Feb. 4, 2011, 1:05 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100554/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 1:05 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Summary says it all.
> 
> 
> Diffs
> -----
> 
>   app/chatwindow.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100554/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110204/7589035e/attachment.htm 


More information about the KDE-Telepathy mailing list