Review Request: ChatUi: Add Send-button

David Edmundson kde at davidedmundson.co.uk
Fri Feb 4 14:35:29 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100548/#review1210
-----------------------------------------------------------


Code is fine. Though there is a big split between those involved as to whether it should exist or not.

Proposal: We can ship this, but: I want a page of "Unsettled issues in the chat handler" on the wiki, and this to be on there.

- David


On Feb. 4, 2011, 12:48 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100548/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 12:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add send button as requested for touch devices.
> 
> 
> Diffs
> -----
> 
>   lib/chatwidget.cpp PRE-CREATION 
>   lib/chatwidget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100548/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110204/b6835121/attachment.htm 


More information about the KDE-Telepathy mailing list