Review Request: Account Identity in Accounts KCM

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103553/#review9303
-----------------------------------------------------------

Ship it!


Awesome. I'm just not too happy about the dialog layout. I suggest passing to for a UI review later. Also, I /think/ that "Edit Identity" is a bit scary button text, but I can't really think of anything better now.


src/accounts-list-model.h
<http://git.reviewboard.kde.org/r/103553/#comment7687>

    You seem to have a bit older code as I edited this last week. Just a heads up to merging issues ;)



src/kcm-telepathy-accounts.cpp
<http://git.reviewboard.kde.org/r/103553/#comment7684>

    Please use the new role I added last week instead of itemForIndex. Which should be evaporated from human history.


- Martin Klapetek


On Dec. 27, 2011, 1:33 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103553/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2011, 1:33 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds a button to the accounts KCM to configure identity (i.e Avatar + Nickname) for an account.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 0927028 
>   src/account-identity-dialog.h PRE-CREATION 
>   src/account-identity-dialog.cpp PRE-CREATION 
>   src/account-identity-dialog.ui PRE-CREATION 
>   src/account-item.h 8a7bde0 
>   src/account-item.cpp bb26b9e 
>   src/accounts-list-model.h 1101172 
>   src/accounts-list-model.cpp b1a6e05 
>   src/avatar-button.h PRE-CREATION 
>   src/avatar-button.cpp PRE-CREATION 
>   src/fetch-avatar-job.h PRE-CREATION 
>   src/fetch-avatar-job.cpp PRE-CREATION 
>   src/kcm-telepathy-accounts.h 8e4b519 
>   src/kcm-telepathy-accounts.cpp fea2ab8 
>   src/main-widget.ui 8ee8aa0 
> 
> Diff: http://git.reviewboard.kde.org/r/103553/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/103553/s/383/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111227/16b45cc2/attachment.html>