Review Request: Support X-MESSENGER-OAUTH2 authentication mechanism and make dialogs modeless

[Daniele Elmo Domenichelli]

> On Dec. 26, 2011, 6:30 p.m., George Kiagiadakis wrote:
> > x-messenger-oauth2-prompt.cpp, line 173
> > <http://git.reviewboard.kde.org/r/103521/diff/2/?file=44813#file44813line173>
> >
> >     I doubt there are any & left in the accessToken at this point
> 
> Dario Freddi wrote:
>     Also, remember to use chars and not strings when splitting ('&'). And in general, I'd wrap any list access around proper checks on its size.
> 
> David Edmundson wrote:
>     Can you not use url.queryItems();

queryItems() is for some reason empty... I think this might be because the query starts with '#' instead of '?'


- Daniele Elmo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103521/#review9283
-----------------------------------------------------------


On Dec. 27, 2011, 9:50 a.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103521/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2011, 9:50 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Refactor SaslAuthOp to support different authentication methods, support X-MESSENGER-OAUTH2 authentication mechanism and make dialogs modeless
> 
> branch here: http://quickgit.kde.org/?p=scratch%2Fddomenichelli%2Ftelepathy-auth-handler.git&a=shortlog&h=refs/heads/oauth2
> 
> At the moment there is no support from the kcm, therefore you will have to add to your ~/.mission-control/accounts/accounts.cfg something like this:
> 
> [gabble/jabber/messenger_2elive_2ecom0]
> manager=gabble
> protocol=jabber
> param-server=xmpp.messenger.live.com
> param-account=messenger.live.com
> param-ignore-ssl-errors=true
> 
> 
> Another way to add it is to create a file /usr/share/telepathy/profiles/msn-xmpp.profile
> 
> <service xmlns="http://telepathy.freedesktop.org/wiki/service-profile-v1"
>          id="msn-xmpp"
>          type="IM"
>          provider="msn-xmpp"
>          manager="gabble"
>          protocol="jabber"
>          icon="im-msn">
>   <name>MSN (using XMPP)</name>
> 
>   <parameters>
>     <parameter name="server"  type="s" mandatory="1">xmpp.messenger.live.com</parameter>
>     <parameter name="port"    type="u" mandatory="1">5222</parameter>
>     <parameter name="ignore-ssl-errors" type="b" mandatory="1">1</parameter>    
>     <parameter name="account" type="s" mandatory="1">messenger.live.com</parameter>
>   </parameters>
> </service>
> 
> And create a new account without changing anything
> 
> 
> Finally you can just create a gabble account setting server "xmpp.messenger.live.com", account name messenger.live.com and enable ignore ssl errors in the advanced settings dialog
> 
> 
> This addresses bugs 283307 and 289668.
>     http://bugs.kde.org/show_bug.cgi?id=283307
>     http://bugs.kde.org/show_bug.cgi?id=289668
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1a263b66349074e8d409adfefd7d53af7d05a07d 
>   password-prompt.h fc686ca4be3cc88cc7f968f6fca6f8a2c89019fe 
>   password-prompt.cpp e23842913c33efce29ff9cc1f474c7acf0449c30 
>   password-prompt.ui 7f5009e0f473bdb3c70a600b70a7f12b8fa6827d 
>   sasl-auth-op.h e58543b6de9b50e05f6d6c5e3ccabf6fa90bc2f3 
>   sasl-auth-op.cpp b65baacc4afa1323fd2392f621b3944d702138c1 
>   sasl-handler.cpp ad34e37e7f757dac1fda95c0f8e8dbece1aae9af 
>   x-messenger-oauth2-auth-operation.h PRE-CREATION 
>   x-messenger-oauth2-auth-operation.cpp PRE-CREATION 
>   x-messenger-oauth2-prompt.h PRE-CREATION 
>   x-messenger-oauth2-prompt.cpp PRE-CREATION 
>   x-telepathy-password-auth-operation.h PRE-CREATION 
>   x-telepathy-password-auth-operation.cpp PRE-CREATION 
>   x-telepathy-password-prompt.h PRE-CREATION 
>   x-telepathy-password-prompt.cpp PRE-CREATION 
>   x-telepathy-password-prompt.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103521/diff/diff
> 
> 
> Testing
> -------
> 
> Can login to MSN using gabble/xmpp
> Can still login using old method (either with password prompt or stored password)
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111227/2e49e3b8/attachment.html>