Review Request: Add configure dialog for account identity.

David Edmundson kde at davidedmundson.co.uk
Sun Dec 25 19:35:54 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103533/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Adds a dialog to configure your identity on an account.

Notes:
 - Code is written to be easily moved to KTp, also written so it can be added to the KCM where we know the account.
 - Needs extending (TpQt4 pending) to support all the contact VCard details.
    I think I can do real only for now.
 - AvatarSpec is rubbish, I want to use it, but it's rubbish.
 - UI isn't quite perfect, it's mostly clear to use (win!), but looks a bit fugly. Constructive comments welcome, I tried a few ideas but not much else worked.


Diffs
-----

  CMakeLists.txt a333f37 
  account-identity.h PRE-CREATION 
  account-identity.cpp PRE-CREATION 
  account-identity.ui PRE-CREATION 
  avatar-button.h b49d5eb 
  avatar-button.cpp 12ef76e 
  contact-list-widget.cpp e59ec51 
  identity-dialog.h PRE-CREATION 
  identity-dialog.cpp PRE-CREATION 
  identity-dialog.ui PRE-CREATION 
  main-widget.h 20d52f1 
  main-widget.cpp 7ad1240 
  main-widget.ui 98e1fe4 

Diff: http://git.reviewboard.kde.org/r/103533/diff/diff


Testing
-------


Screenshots
-----------


  http://git.reviewboard.kde.org/r/103533/s/382/


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111225/84e00caf/attachment-0001.html>


More information about the KDE-Telepathy mailing list