Review Request: Support drag and drop file transfer

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103520/#review9245
-----------------------------------------------------------

Ship it!


minor comment, but then ship it!


contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/103520/#comment7651>

    If I read this code correctly you're grabbing the entire line from the view - i.e avatar + name + icon etc.
    
    If so, don't  call the pixmap avatar :-)


- David Edmundson


On Dec. 24, 2011, 10:56 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103520/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2011, 10:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds support for drag and drop file transfer.
> Before the model handled the drag and drop of contacts between groups,
> but with reimplementing the drag*Event methods this stopped working so I moved the logic in the view.
> (I will later clean up the model, I'm sure now there is unused code.)
> 
> 
> This addresses bug 288560.
>     http://bugs.kde.org/show_bug.cgi?id=288560
> 
> 
> Diffs
> -----
> 
>   contact-list-widget_p.h 9f9914616be89884f5d2971782fa0c3cf20d3ac0 
>   contact-list-widget.h 85cac2a3912b127589757d95a32c64fa40444979 
>   contact-list-widget.cpp 3d4362442eb37577fcf067b1bd24daa80222b196 
> 
> Diff: http://git.reviewboard.kde.org/r/103520/diff/diff
> 
> 
> Testing
> -------
> 
> Drag and dropping contacts to groups works.
> Dropping one or more local file(s) over a contact starts the filetransfer(s).
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111225/bba111d3/attachment-0001.html>