Review Request: Support drag and drop file transfer

[Daniele Elmo Domenichelli]

> On Dec. 23, 2011, 3:35 p.m., Daniele Elmo Domenichelli wrote:
> > contact-list-widget.cpp, lines 613-628
> > <http://git.reviewboard.kde.org/r/103520/diff/1/?file=44645#file44645line613>
> >
> >     This part is duplicated from line 497, I'd add a method (QStringList fileNames, QDateTime userActionTime)
> >
> 
> Dominik Cermak wrote:
>     The method also needs the account, but I'm not sure what's better:
>     void requestFileTransferChannels(Tp::AccountPtr *account, QStringList filenames, QDateTime userActionTime);
>     or
>     void requestFileTransferChannels(Tp::AccountPtr account, QStringList filenames, QDateTime userActionTime);
>     
>     Can someone please enlighten me?

I'd say
requestFileTransferChannels(const Tp::AccountPtr &account,
                            const QStringList &filenames,
                            const QDateTime &userActionTime);


- Daniele Elmo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103520/#review9205
-----------------------------------------------------------


On Dec. 23, 2011, 3:02 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103520/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2011, 3:02 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds support for drag and drop file transfer.
> Before the model handled the drag and drop of contacts between groups,
> but with reimplementing the drag*Event methods this stopped working so I moved the logic in the view.
> (I will later clean up the model, I'm sure now there is unused code.)
> 
> 
> This addresses bug 288560.
>     http://bugs.kde.org/show_bug.cgi?id=288560
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h 85cac2a3912b127589757d95a32c64fa40444979 
>   contact-list-widget.cpp 3d4362442eb37577fcf067b1bd24daa80222b196 
> 
> Diff: http://git.reviewboard.kde.org/r/103520/diff/diff
> 
> 
> Testing
> -------
> 
> Drag and dropping contacts to groups works.
> Dropping one or more local file(s) over a contact starts the filetransfer(s).
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111223/1108326b/attachment.html>