Review Request: Rename approver according to the new policy

George Kiagiadakis kiagiadakis.george at gmail.com
Fri Dec 23 10:58:41 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103508/#review9196
-----------------------------------------------------------


You also missed the KAboutData in tpkdeapprovermodule.cpp


src/Messages.sh
<http://git.reviewboard.kde.org/r/103508/#comment7595>

    kded_ktp_approver.po, like the kded module



src/ktp_approverrc
<http://git.reviewboard.kde.org/r/103508/#comment7596>

    s/KDE/KTp/


- George Kiagiadakis


On Dec. 22, 2011, 5:28 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103508/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2011, 5:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> As summary.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt db14ab6 
>   src/CMakeLists.txt 05956d4 
>   src/Messages.sh 1ac139b 
>   src/ktp_approver.desktop PRE-CREATION 
>   src/ktp_approverrc PRE-CREATION 
>   src/telepathy_kde_approver.desktop ac06bbc 
>   src/telepathy_kde_approverrc eb7df2e 
> 
> Diff: http://git.reviewboard.kde.org/r/103508/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111223/2b832f87/attachment.html>


More information about the KDE-Telepathy mailing list