Review Request: Rename accounts-kcm according to the new policy
Martin Klapetek
martin.klapetek at gmail.com
Thu Dec 22 10:36:04 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103502/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
This has actually lots of libraries, so I named the main kcm one according to the kcm scheme, its internal library is now 'libktpaccountskcminternal', while the plugins are 'ktpaccountskcm_plugin_X.so', which I'm not sure about. Should I turn it to 'libktpaccountskcm_plugin_X.so' or 'libktpaccountskcmpluginX.so'?
Diffs
-----
CMakeLists.txt 2a9aef2
plugins/butterfly/CMakeLists.txt 26859c9
plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop 3df354a
plugins/gabble/CMakeLists.txt 81ba67d
plugins/gabble/ktpaccountskcm_plugin_gabble.desktop 62c501c
plugins/haze/CMakeLists.txt dfedda5
plugins/haze/ktpaccountskcm_plugin_haze.desktop f044014
plugins/idle/CMakeLists.txt 3b91531
plugins/idle/ktpaccountskcm_plugin_idle.desktop adf8078
plugins/rakia/CMakeLists.txt bfa8da7
plugins/rakia/ktpaccountskcm_plugin_rakia.desktop 906f1d6
plugins/salut/CMakeLists.txt 80da74f
plugins/salut/ktpaccountskcm_plugin_salut.desktop 98ea8e3
plugins/sunshine/CMakeLists.txt 0a08d7a
plugins/sunshine/ktpaccountskcm_plugin_sunshine.desktop aceac75
src/CMakeLists.txt 60542b2
src/KCMTelepathyAccounts/CMakeLists.txt 581edcf
src/account-item.h 8a7bde0
src/accounts-list-delegate.cpp f670e0f
src/accounts-list-model.h 1101172
src/accounts-list-model.cpp b1a6e05
src/kcm-telepathy-accounts.cpp 55d2853
src/kcm_telepathy_accounts.desktop cd20e22
Diff: http://git.reviewboard.kde.org/r/103502/diff/diff
Testing
-------
Successfully created an account. Everything works.
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111222/7942b166/attachment.html>
More information about the KDE-Telepathy
mailing list