Review Request: Use KTelepathy (and in particular KTp::Presence) in the Text UI.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103493/#review9153
-----------------------------------------------------------

Ship it!


Great, that class was really awesome idea. Couple whitespaces were left over, I pointed them all out so you can just go down this list. Also you should either wait for the naming changes and then rebase this patch, or commit this right now and make George K. angry.


lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/103493/#comment7583>

    Whitespace



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/103493/#comment7580>

    Whitespace



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/103493/#comment7582>

    Whitespace



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/103493/#comment7581>

    Whitespace


- Martin Klapetek


On Dec. 21, 2011, 6:37 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103493/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 6:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use KTelepathy (and in particular KTp::Presence) in the Text UI.
> 
> This simplifies code and removes a lot from the TextUI.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f2a59ad 
>   cmake/modules/FindKTelepathy.cmake PRE-CREATION 
>   lib/CMakeLists.txt 8ffc494 
>   lib/channel-contact-model.h 4ebdafe 
>   lib/channel-contact-model.cpp 78bd7be 
>   lib/chat-widget.h 8253816 
>   lib/chat-widget.cpp b55b81d 
> 
> Diff: http://git.reviewboard.kde.org/r/103493/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111221/843cfb39/attachment.html>