Review Request: Move contact list view to a separate class, easily embeddable

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103481/
-----------------------------------------------------------

(Updated Dec. 20, 2011, 8:56 p.m.)


Review request for Telepathy.


Changes
-------

Fixed all raised comments.


Description
-------

This second part moves the actual view out of MainWidget to a separate ContactListWidget class. The separate private class is mainly for the context menu, which needs access to the private variables. The widget should be fully self contained with public slots to change its behaviour/look (switch between groups/accounts, show offline users etc). All error messages are sent out as signals and picked by MainWidget, which displays the actual notifications. All Tp stuff was also moved there.


This addresses bug 279107.
    http://bugs.kde.org/show_bug.cgi?id=279107


Diffs (updated)
-----

  CMakeLists.txt e6d7cea 
  contact-list-widget.h PRE-CREATION 
  contact-list-widget.cpp PRE-CREATION 
  contact-list-widget_p.h PRE-CREATION 
  context-menu.h 178cdf0 
  context-menu.cpp fff8c7a 
  main-widget.h f01b377 
  main-widget.cpp 1d3e10c 
  main-widget.ui d71a276 

Diff: http://git.reviewboard.kde.org/r/103481/diff/diff


Testing
-------

Tested all actions. Started chat etc. All works.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111220/973c6c45/attachment.html>