Review Request: Fix krazy issues in text-ui

David Edmundson kde at davidedmundson.co.uk
Tue Dec 20 18:31:04 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103480/#review9124
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Dec. 20, 2011, 6:19 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103480/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2011, 6:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Remove double include.
> Fix header guards.
> Normalize signal.
> Fix typo.
> Use const & for foreach.
> Validate xml.
> Fix ambiguous translations.
> Fix newline.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp ebec3e74d5c65e7d009fd4c5342433c885c8bda9 
>   app/chatwindow.rc 1edb7d167b9bb13128cb553d3918c0c97bdc2cfd 
>   config/appearance-config.h e3da64c00b4016b0f545ed87471ead92a4df58dc 
>   config/behavior-config.ui 9228db6cfb08b399acf1a84616a11a8d531dbc15 
>   lib/channel-contact-model.h 91fe4ada03ee8288bb493583db7cd8d53c98ec76 
>   lib/chat-search-bar.cpp 528472f78b06a5ff89edb1f7efffbb5af87c655d 
>   lib/chat-widget.cpp dbac767a81e0d574f2b7b54794d9b2e907ebbcf0 
>   lib/chat-window-style.cpp e86e93a18e1f731b7101ffb96a598ff69189d453 
>   lib/logmanager.cpp f623526b3ff9123edc5ef2fcf7b25cbc579e1136 
> 
> Diff: http://git.reviewboard.kde.org/r/103480/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111220/79145e66/attachment.html>


More information about the KDE-Telepathy mailing list