Review Request: Move context menu related stuff outside to a separate class

Commit Hook null at kde.org
Tue Dec 20 12:12:15 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103477/#review9121
-----------------------------------------------------------


This review has been submitted with commit 32cdb447b3f61bb925e7b6670f2a8da434678895 by Martin Klapetek to branch master.

- Commit Hook


On Dec. 19, 2011, 6:57 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103477/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2011, 6:57 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> That makes MainWidget significantly lighter and easier to manage as /the widget/. Basically it just moves everything to ContextMenu, makes it friend class of MainWidget and thus allowing access to the private members like models etc.
> 
> Next step is to separate the window logic from the widget itself and have the contact list widget 100% reusable as-is.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5067b8b 
>   context-menu.h PRE-CREATION 
>   context-menu.cpp PRE-CREATION 
>   main-widget.h b700a59 
>   main-widget.cpp 1a91516 
> 
> Diff: http://git.reviewboard.kde.org/r/103477/diff/diff
> 
> 
> Testing
> -------
> 
> Everything works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111220/7d00c8db/attachment.html>


More information about the KDE-Telepathy mailing list