Review Request: Move context menu related stuff outside to a separate class

Martin Klapetek martin.klapetek at gmail.com
Mon Dec 19 18:57:37 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103477/
-----------------------------------------------------------

(Updated Dec. 19, 2011, 6:57 p.m.)


Review request for Telepathy.


Changes
-------

Sort out the #include mess.


Description
-------

That makes MainWidget significantly lighter and easier to manage as /the widget/. Basically it just moves everything to ContextMenu, makes it friend class of MainWidget and thus allowing access to the private members like models etc.

Next step is to separate the window logic from the widget itself and have the contact list widget 100% reusable as-is.


Diffs (updated)
-----

  CMakeLists.txt 5067b8b 
  context-menu.h PRE-CREATION 
  context-menu.cpp PRE-CREATION 
  main-widget.h b700a59 
  main-widget.cpp 1a91516 

Diff: http://git.reviewboard.kde.org/r/103477/diff/diff


Testing
-------

Everything works.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111219/a9e02111/attachment.html>


More information about the KDE-Telepathy mailing list