Review Request: Fix outstanding krazy issues in accounts-kcm

David Edmundson kde at davidedmundson.co.uk
Thu Dec 15 17:03:56 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103418/#review8980
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Dec. 15, 2011, 4:55 p.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103418/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2011, 4:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> As the title says
> 
>       fix-krazy: Fix copyright headers
>       fix-krazy: Fix crashy dialogs
>       fix-krazy: Fix newlines
>       fix-krazy: Make constructors explicit
>       fix-krazy: Fix copyright header
>       fix-krazy: Normalize signatures
>       fix-krazy: Move to K Classes
>       fix-krazy: Fix typos
>       fix-krazy: Fix K classes in designer
>       fix-krazy: Add missing copyrights
>       fix-krazy: Fix ambiguous translations
> 
> 
> Diffs
> -----
> 
>   plugins/butterfly/butterfly-account-ui-plugin.h aa6c14c 
>   plugins/butterfly/butterfly-account-ui-plugin.cpp c3d605d 
>   plugins/butterfly/butterfly-account-ui.h b768a18 
>   plugins/butterfly/butterfly-account-ui.cpp fff3ddd 
>   plugins/butterfly/main-options-widget.h 9aee8bc 
>   plugins/butterfly/main-options-widget.cpp 81fd2c8 
>   plugins/gabble/gabble-account-ui-plugin.h a9cbbdb 
>   plugins/gabble/gabble-account-ui-plugin.cpp 4fbc138 
>   plugins/gabble/gabble-account-ui.h 99a1960 
>   plugins/gabble/gabble-account-ui.cpp ae2d2b0 
>   plugins/gabble/main-options-widget.h e6a7112 
>   plugins/gabble/main-options-widget.cpp 28bc39a 
>   plugins/gabble/proxy-settings-widget.h 0abec3a 
>   plugins/gabble/proxy-settings-widget.cpp 40727c7 
>   plugins/gabble/server-settings-widget.h 1237c9e 
>   plugins/gabble/server-settings-widget.cpp 224c181 
>   plugins/gabble/server-settings-widget.ui 95c5cea 
>   plugins/haze/aim-main-options-widget.h 607fce3 
>   plugins/haze/haze-msn-account.h 7721d30 
>   plugins/haze/yahoo-main-options-widget.h 3c5581e 
>   plugins/rakia/rakia-account-ui.cpp bfc455e 
>   plugins/rakia/rakia-advanced-options-widget.ui 89febce 
>   plugins/sunshine/sunshine-account-ui.cpp deace76 
>   plugins/sunshine/sunshine-advanced-options-widget.ui aaf5ad7 
>   src/KCMTelepathyAccounts/abstract-account-parameters-widget.h c692681 
>   src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp cdc2137 
>   src/KCMTelepathyAccounts/abstract-account-ui-plugin.h 67c68c0 
>   src/KCMTelepathyAccounts/abstract-account-ui-plugin.cpp 8164a02 
>   src/KCMTelepathyAccounts/abstract-account-ui.h 9494e7a 
>   src/KCMTelepathyAccounts/abstract-account-ui.cpp 500452b 
>   src/KCMTelepathyAccounts/account-edit-widget.h 6609618 
>   src/KCMTelepathyAccounts/account-edit-widget.cpp 425e7b2 
>   src/KCMTelepathyAccounts/dictionary.h fabb9eb 
>   src/KCMTelepathyAccounts/dictionary.cpp d139261 
>   src/KCMTelepathyAccounts/parameter-edit-delegate.h 1e58874 
>   src/KCMTelepathyAccounts/parameter-edit-delegate.cpp 9241736 
>   src/KCMTelepathyAccounts/parameter-edit-model.h f53577b 
>   src/KCMTelepathyAccounts/parameter-edit-model.cpp 70f5914 
>   src/KCMTelepathyAccounts/parameter-edit-widget.h eed77e0 
>   src/KCMTelepathyAccounts/parameter-edit-widget.cpp 34e161a 
>   src/KCMTelepathyAccounts/parameter-item.h b5648ee 
>   src/KCMTelepathyAccounts/parameter-item.cpp 3bf88c4 
>   src/KCMTelepathyAccounts/plugin-macros.h 7c33108 
>   src/KCMTelepathyAccounts/plugin-manager.h dd8df10 
>   src/KCMTelepathyAccounts/plugin-manager.cpp 9ca6630 
>   src/KCMTelepathyAccounts/profile-item.h 11e2eaf 
>   src/KCMTelepathyAccounts/profile-item.cpp 6382e79 
>   src/KCMTelepathyAccounts/profile-list-model.h 9917555 
>   src/KCMTelepathyAccounts/profile-list-model.cpp dcffa68 
>   src/KCMTelepathyAccounts/profile-select-widget.h 516cc57 
>   src/KCMTelepathyAccounts/profile-select-widget.cpp d8f073a 
>   src/KCMTelepathyAccounts/unsigned-integer-edit.h c4c7538 
>   src/KCMTelepathyAccounts/unsigned-integer-edit.cpp bf2b8b4 
>   src/account-item.h 6e2afd7 
>   src/account-item.cpp b560cdf 
>   src/accounts-list-model.h e0a8461 
>   src/accounts-list-model.cpp a77ff56 
>   src/add-account-assistant.h 2630531 
>   src/add-account-assistant.cpp d2b33dd 
>   src/edit-account-dialog.h e57f6f2 
>   src/edit-account-dialog.cpp 82cf59e 
>   src/kcm-telepathy-accounts.h a752065 
>   src/kcm-telepathy-accounts.cpp b23e02e 
>   src/salut-details-dialog.h 6d970b6 
>   src/salut-details-dialog.cpp 465bde3 
>   src/salut-enabler.h 25bd4f8 
>   src/salut-enabler.cpp 9bc3ba2 
>   src/salut-message-widget.cpp 0ab5c1a 
> 
> Diff: http://git.reviewboard.kde.org/r/103418/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario Freddi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111215/b1698710/attachment.html>


More information about the KDE-Telepathy mailing list