Review Request: Add filtering for filetransfer-capability and make filtering more generic

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103409/#review8953
-----------------------------------------------------------



KTelepathy/Models/accounts-filter-model.h
<http://git.reviewboard.kde.org/r/103409/#comment7438>

    there are /lots/ of capabilities, I don't think this can be done as a bool.
    
    Suggest passing a RequestableChannelClassSpec (or maybe even RequestableChannelClassSpecList?) as the argument. 
    
    Then later:
    if (contactPtr.capabilities)(.allClassSpecs().contains(m_capability) 
    
    Currenty this is a very generic term for a very specific capability.
    
    Alternately (if we're being lazy) we could make a filterByFileTransferCapability()


- David Edmundson


On Dec. 14, 2011, 12:53 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103409/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2011, 12:53 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add the possibility to filter for contacts with filetransfer capability as it is needed for send-file.
> Filtering for name now respects showOfflineUsers (was previously hardcoded for contact-list, another review following to restore the desired behaviour in contact-list).
> 
> 
> Diffs
> -----
> 
>   KTelepathy/Models/accounts-filter-model.h 5a058e2 
>   KTelepathy/Models/accounts-filter-model.cpp ca7aa91 
> 
> Diff: http://git.reviewboard.kde.org/r/103409/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111214/aa40249c/attachment.html>