Review Request: add /me support
Dario Freddi
drf at kde.org
Tue Dec 13 20:13:57 UTC 2011
> On Dec. 5, 2011, 11:20 p.m., David Edmundson wrote:
> > lib/chat-widget.cpp, line 687
> > <http://git.reviewboard.kde.org/r/103338/diff/1/?file=42791#file42791line687>
> >
> > You idiot, this doesn't check the supported message types.
> >
> > That was the whole reason for waiting for the TpQt4 patch.
David, now that we depend on tp-qt which has the patch you need, do you have a second for finishing the work on this patch?
- Dario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103338/#review8742
-----------------------------------------------------------
On Dec. 5, 2011, 6:36 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103338/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2011, 6:36 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Make use of the new messageTypes method in TpQt4 and support sending and receiving action messages.
>
>
> Diffs
> -----
>
> lib/chat-widget.cpp 2971b67
>
> Diff: http://git.reviewboard.kde.org/r/103338/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111213/4d8c8277/attachment.html>
More information about the KDE-Telepathy
mailing list