Review Request: Replace Feedback widget with KMessageWidget

Dominik Cermak d.cermak at arcor.de
Tue Dec 13 16:55:22 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103398/
-----------------------------------------------------------

(Updated Dec. 13, 2011, 4:55 p.m.)


Review request for Telepathy.


Changes
-------

FeedbackWidget now derives from KMessageWidget.


Description
-------

Replaced all occurrences of FeedbackWidget with KMessageWidget.
Also turned two Informative messages into Error messages to make it consistent.


This addresses bug 283869.
    http://bugs.kde.org/show_bug.cgi?id=283869


Diffs (updated)
-----

  src/KCMTelepathyAccounts/account-edit-widget.h 52dc89d 
  src/KCMTelepathyAccounts/account-edit-widget.cpp 14f1b75 
  src/KCMTelepathyAccounts/feedback-widget.h e547857 
  src/KCMTelepathyAccounts/feedback-widget.cpp 057456a 
  src/KCMTelepathyAccounts/parameter-edit-model.h 3b2b08b 
  src/KCMTelepathyAccounts/parameter-edit-model.cpp f461674 
  src/add-account-assistant.h b85d44e 
  src/add-account-assistant.cpp 1c2e90d 
  src/salut-details-dialog.h 5a36adc 
  src/salut-details-dialog.cpp 46fb94c 
  src/salut-enabler.h 8a86133 
  src/salut-enabler.cpp ca7a46e 

Diff: http://git.reviewboard.kde.org/r/103398/diff/diff


Testing
-------


Screenshots
-----------

Old version with FeedbackWidget
  http://git.reviewboard.kde.org/r/103398/s/367/
New version with KMessageWidget
  http://git.reviewboard.kde.org/r/103398/s/368/


Thanks,

Dominik Cermak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111213/059a8a6c/attachment-0001.html>


More information about the KDE-Telepathy mailing list