Review Request: supress sending info about user currently typing to contact

[Dario Freddi]

> On Dec. 11, 2011, 10:42 p.m., Dominik Schmidt wrote:
> > Hey,
> > 
> > I don't have strong opinions nor do I want to start a flame war, just giving a heads up:
> > 
> > please keep this in mind:
> > http://agateau.wordpress.com/2010/12/27/common-user-interface-mistakes-in-kde-applications-part-2-dialog-layouts/
> > 
> > and also take a look at this (referenced above too) as well:
> > http://techbase.kde.org/Projects/Usability/HIG/Form_Label_Alignment
> > 
> > Best regards,
> > Dominik

Yes, the layout is totally broken here and should be fixed. About the option itself, I don't know if it makes a lot of sense. What's the rationale behind it?


- Dario


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103385/#review8879
-----------------------------------------------------------


On Dec. 11, 2011, 3:11 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103385/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2011, 3:11 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch is a remake of the general chat config and adds the option to supress sending the "user is typing" info to contact we're currently in a chat with
> 
> 
> This addresses bug 282201.
>     http://bugs.kde.org/show_bug.cgi?id=282201
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 4afa8a1 
>   app/chat-window.cpp d45cf57 
>   config/behavior-config.h 55d2fea 
>   config/behavior-config.cpp 65ddab9 
>   config/behavior-config.ui 9228db6 
>   config/kcm_telepathy_chat_behavior_config.desktop e0c45f5 
>   lib/chat-widget.h 7ea41eb 
>   lib/chat-widget.cpp e28d52e 
> 
> Diff: http://git.reviewboard.kde.org/r/103385/diff/diff
> 
> 
> Testing
> -------
> 
> spammed martin without him knowing i was typing.
> 
> 
> Screenshots
> -----------
> 
> preview
>   http://git.reviewboard.kde.org/r/103385/s/361/
> 
> 
> Thanks,
> 
> Francesco Nwokeka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111212/44f4057d/attachment.html>