Review Request: add /me support
Dario Freddi
drf at kde.org
Mon Dec 5 23:11:28 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103338/#review8741
-----------------------------------------------------------
Ship it!
I should reject this just for the patch you made me merge in Tp-Qt and came out to be useless!! :D Just kidding ofc, great you got around this. Just one small issue here.
P.S.: Remember to add the relevant bug to the review just to keep things on track
lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/103338/#comment7341>
This i18n is obscure. If the message is not locale-dependent, it should not be translated. If it is, a rather explanatory comment should be added
lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/103338/#comment7342>
Same here
- Dario Freddi
On Dec. 5, 2011, 6:36 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103338/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2011, 6:36 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Make use of the new messageTypes method in TpQt4 and support sending and receiving action messages.
>
>
> Diffs
> -----
>
> lib/chat-widget.cpp 2971b67
>
> Diff: http://git.reviewboard.kde.org/r/103338/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111205/2cf635bc/attachment.html>
More information about the KDE-Telepathy
mailing list